Ticket #83 (closed enhancement: wontfix)

Opened 5 years ago

Last modified 2 years ago

[PATCH] Wymeditor with thickbox

Reported by: pc Owned by: jf.hovinne
Priority: major Milestone:
Component: editor Version: trunk
Keywords: Cc: pc@…

Description

I'm attaching patch which will make all dialogs appear in thickbox. It's currently PoC patch. But as you can see changes are minimal, so it can be configurable whether to use thickbox or popups.

The problems currently are:

  • Dialog size is same as popup size, it can be inappropriate
  • Thickbox default css removes all margins, I don't know why, but I believe it's fixable
  • Possibly preview needs to be displayed into at least in an iframe to load different stylesheet

Any suggestions? Is it worth to work on?

Attachments

wymeditor_thickbox.diff Download (6.5 KB) - added by pc 5 years ago.

Change History

Changed 5 years ago by pc

comment:1 Changed 5 years ago by pc

You need  thickbox.js,  thickbox.css for this to work

comment:2 Changed 4 years ago by sitespark

Im very interested in this.

Because of:  http://forum.wymeditor.org/forum/viewtopic.php?f=2&t=425&p=1527&hilit=thickbox&sid=056bb9033fa7a7a43cd29e5e38f9e5af#p1527

Is this now deprecated?

comment:3 Changed 4 years ago by jf.hovinne

A cross-browser version of the patch would be interesting - my time is too limited right now to work on this. Any help is welcome.

Anyway, popups will be replaced by overlays in 0.6.

comment:4 Changed 2 years ago by mr_lundis

  • Status changed from new to closed
  • Resolution set to wontfix

I'm dropping this for now. A new dialog api, with overlaying js dialogs is planned for 0.6 as stated earlier.

Note: See TracTickets for help on using tickets.