Ticket #197 (closed defect: invalid)

Opened 2 years ago

Last modified 2 years ago

typo in jquery.wymeditor.js 5.0rc1, trunk

Reported by: dpb Owned by: jf.hovinne
Priority: major Milestone: 0.5
Component: editor Version: trunk
Keywords: Cc:


Looks like a double-quote went missing...

Index: jquery.wymeditor.js
--- jquery.wymeditor.js	(revision 648)
+++ jquery.wymeditor.js	(working copy)
@@ -3043,7 +3043,7 @@
 WYMeditor.XhtmlParser.prototype.beforeParsing = function(raw)
-  if(raw.match(/class="MsoNormal"/) || raw.match(/ns = "urn:schemas-microsoft-com/)){
+  if(raw.match(/class="MsoNormal"/) || raw.match(/ns = "urn:schemas-microsoft-com/")){
     // Usefull for cleaning up content pasted from other sources (MSWord)

Change History

comment:1 Changed 2 years ago by dpb

The patch isn't quite right; the added double-quote goes *before* the slash - it should read:

raw.match(/ns = "urn:schemas-microsoft-com"/)){

On the other hand, maybe it's not a problem at all and this is a context where quotes don't need to be matched, even though it confused my emacs highlighting...

Just toss the bug if in fact this is not really a problem.

comment:2 Changed 2 years ago by dpb

  • Status changed from new to closed
  • Resolution set to invalid

Looks legal, shows you how little I know javascript...

Note: See TracTickets for help on using tickets.