Ticket #128 (closed defect: wontfix)

Opened 4 years ago

Last modified 4 years ago

jquery with google loader

Reported by: martinsarsini Owned by: jf.hovinne
Priority: minor Milestone: 0.5
Component: editor Version: trunk
Keywords: jquery google loader Cc:

Description

I am using Google loader and the latest version of jquery, but I am getting errors if I am using the preview functionality and the insert table. I know that it is caused by using google loader instead of embedding directly the jquery file.

But I am sure many people are using the google loader solution and would be great to hat WYMeditor supporting this.

Change History

comment:1 Changed 4 years ago by jf.hovinne

  • Status changed from new to assigned

Could you please post the errors messages, or provide a test page?

Thanks.

comment:2 Changed 4 years ago by martinsarsini

 http://nsapps.co.uk/wymeditor/examples/01-basic.html

I uploaded the latest version of WYMeditor 0.5 beta 1 I just changed the line of the jquery library inclusion and added

<script src=" http://www.google.com/jsapi"></script> <script>google.load("jquery", "1.2.6");</script>

comment:3 Changed 4 years ago by jf.hovinne

  • Priority changed from major to minor
  • Milestone set to 0.5

Actually you can change the dialogs HTML to also use the 'Google loader', by using the dialogHtml option: 

dialogHtml:     '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"'
              + ' "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">'
              + '<html dir="'
              + WYMeditor.DIRECTION
              + '"><head>'
              + '<link rel="stylesheet" type="text/css" media="screen"'
              + ' href="'
              + WYMeditor.CSS_PATH
              + '" />'
              + '<title>'
              + WYMeditor.DIALOG_TITLE
              + '</title>'
              + '<script type="text/javascript">'
              + 'window.opener.google.load("jquery", "1.2.6");'
              + '<\/script>'
              + '<script type="text/javascript"'
              + ' src="'
              + WYMeditor.WYM_PATH
              + '"><\/script>'
              + '</head>'
              + WYMeditor.DIALOG_BODY
              + '</html>'

Unfortunately something prevents jQuery to load correctly...

Anyway, why don't you simply use the release file provided by jQuery? 

<script type="text/javascript" src="http://code.jquery.com/jquery-latest.min.js"></script>

comment:4 Changed 4 years ago by jf.hovinne

  • Status changed from assigned to closed
  • Resolution set to wontfix

Will be fixed in 0.6 (popups replaced by overlays, so no need to reload JS files).

Note: See TracTickets for help on using tickets.