Ticket #70 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 years ago

WYMeditor's HTML structure

Reported by: dixon_ Owned by: jf.hovinne
Priority: minor Milestone: 0.5
Component: editor Version: trunk
Keywords: Cc:

Description (last modified by d.reszka) (diff)

I ran into some issues when customizing wymeditor's stylesheet. I think the default inline margin rules applied to div.wym_area_left and div.wym_area_right shall be removed. They makes it hard to move areas around, without touching jquery.wymeditor.js. Another issue is the border around the iframe applied by default. I think the frameborder attribute shall be set to "0" in the iframe tag by default. Then you can customize the border style completely through the skin's stylesheet.

Change History

  Changed 3 years ago by dixon_

  • priority changed from major to minor
  • type changed from defect to enhancement

in reply to: ↑ description   Changed 3 years ago by d.reszka

  • description modified (diff)

Replying to dixon_:

I ran into some issues when customizing wymeditor's stylesheet. I think the default inline margin rules applied to div.wym_area_left and div.wym_area_right shall be removed. They makes it hard to move areas around, without touching jquery.wymeditor.js. Another issue is the border around the iframe applied by default. I think the frameborder attribute shall be set to "0" in the iframe tag by default. Then you can customize the border style completely through the skin's stylesheet.

  Changed 3 years ago by d.reszka

  • description modified (diff)

  Changed 3 years ago by d.reszka

If you talk about the margins on the div "wym_area_main", they are added using javascript to make some space for the side areas ("wym_area_left" and "wym_area_right") if they are not empty.

So for example if you put some menus "in wym_area_left", some margin will be added using javascript to make the space needed available.

You can change all this by creating your custom skin, you should find the needed infos in the doc and the examples.

You can already customise the borders of the iframe just by using CSS, why would it be better to use the frameborder attribute ?

  Changed 3 years ago by jf.hovinne

  • status changed from new to assigned
  • milestone changed from 0.4 to 0.5

Anyway, I think we need a true skin system, i.e. switching from one skin to another using the skin option, and more easily customizing skins. Moved to 0.5.

  Changed 2 years ago by jf.hovinne

  • status changed from assigned to closed
  • resolution set to fixed

Fixed by r478 and r479. Skin system available.

Note: See TracTickets for help on using tickets.