IE: Page jumps to top when Container (H1, H2, ...) is clicked

[mh]

In IE (v8, dont know about previous versions, but assume it's the same there) the pages jumps to the top if you click on any of the containers' elements (heading 1 thru 6, paragraph, ...)

Easy solution: replace all href="#" with href="javascript://". Then you don't even need the return false; statement anymore!

[mr_lundis]

The "jumping" is caused by an exception thrown by IE - a fix is needed. See this discussion for further details: http://stackoverflow.com/questions/122546/what-to-do-when-ies-movetoelementtext-spits-out-an-invalid-argument-exception

[mh]

i think it's a good idea to change the href attribute anyways. cause all those links do not *mean* to go to an anchor (which is what href="#" stands for). this is a semantic editor after all. ;-)

[mr_lundis]

If we're talking semantics then none of all those buttons should be links to begin with. But since IE is a pain they need to be, otherwise the styling breaks unless we introduce a bunch of unnecessary event listeners and classes.

My point was however that it's not the href value that's the real cause of the problem, but how IE handles DOM node handles. ;)

[weswinham]

I think the actual problem here might be that focus is lost when clicking the container links in ie8, the focus is lost. Maybe this is an ie8 only issue, though.

I added a patch in my github branch with a simple fix: http://github.com/winhamwr/wymeditor/commit/16a3a6cc6e07ee5d2677f29e79f2464557ec6c01

So clicking the containers no longer jumps to the top of the screen in ie8 now.

[mr_lundis]

Replying to weswinham:

I think the actual problem here might be that focus is lost when clicking the container links in ie8, the focus is lost. Maybe this is an ie8 only issue, though. I added a patch in my github branch with a simple fix: http://github.com/winhamwr/wymeditor/commit/16a3a6cc6e07ee5d2677f29e79f2464557ec6c01 So clicking the containers no longer jumps to the top of the screen in ie8 now.

Could you test your fix in some earlier versions of IE?

[weswinham]

Just tested this patch in:

• ie6
• ie7
• ie8 (in and out of compatibility mode)
• chrome 6dev
• FF 3.6

Containers work in all of them and the screen no longer jumps to the top in ie8. Also, virtualbox is awesome :)

[mr_lundis]

Nice! I'll be including that ASAP, now I need to sleep though, otherwise I won't get up for work tomorrow!

Also, I don't know how we did testing before VirtualBox, it's awesome indeed!

[mr_lundis]

Fix in r674. Moved it into the load skin method.