Ticket #122 (closed defect: fixed)

Opened 23 months ago

Last modified 22 months ago

compatibility jQuery < 1.2.3

Reported by: lemisterv Owned by: jf.hovinne
Priority: minor Milestone:
Component: editor Version: trunk
Keywords: compatibility jquery Cc:

Description

/trunk/src/wymeditor/jquery.wymeditor.js line 727 :

jQuery(this._box).data(WYMeditor.WYM_INDEX, this._index);

function jQuery().data was added in jQuery 1.2.3 So WymEditor doesn't work anymore with jQuery < 1.2.3

By commenting this line 727, WymEditor works again in jQuery 1.1.3

I don't see any bad effect in removing this line... So it should be a good thing to make something like :

if(jQuery().data)
	jQuery(this._box).data(WYMeditor.WYM_INDEX, this._index);

Change History

Changed 22 months ago by jf.hovinne

  • status changed from new to closed
  • resolution set to fixed

Agreed. See r549.

FYI the stored data is useful when you want to know the current WYMeditor instance index, so I'll recommend updating jQuery to 1.2.3+

Thanks for the patch!

Note: See TracTickets for help on using tickets.